Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: PropertyCollector WaitForUpdatesEx incremental change detection #922

Closed
ausevj opened this issue Nov 17, 2017 · 0 comments
Closed

Comments

@ausevj
Copy link

ausevj commented Nov 17, 2017

Putting up a feature request to support incremental change detection for PropertyFilter in PropertyCollector (WaitForUpdatesEx) - version number should increase incrementally as well as support ObjectUpdateKind (enter, leave, modify).

Using WaitForUpdatesEx on real VCenter we only get the response when at least one of the properties in the specified filter has changed. The returned version is a number string increasing by 1 (initial being an empty string) with each response.

@dougm dougm self-assigned this Nov 17, 2017
@dougm dougm added this to the 2018.08-1 milestone May 22, 2018
dougm added a commit to dougm/govmomi that referenced this issue Jul 9, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.ModifyObject method instead of setting fields directly.
ModifyObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  ModifyObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 9, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.ModifyObject method instead of setting fields directly.
ModifyObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  ModifyObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 9, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.ModifyObject method instead of setting fields directly.
ModifyObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  ModifyObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 9, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 10, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 10, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 11, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 11, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 12, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 12, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 12, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 13, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 13, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 13, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 13, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 13, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 14, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 14, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 14, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 15, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 16, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 17, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 18, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 18, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 18, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 19, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 19, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 19, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
dougm added a commit to dougm/govmomi that referenced this issue Jul 19, 2018
Prior to this change, clients could only call WaitForUpdatesEx once,
which would return the current state.  The next invocation with Version
given would fail as unsupported.  Clients can now use WaitForUpdatesEx
to wait for multiple updates.

The basic idea is that methods should now update object fields using
the Registry.UpdateObject method instead of setting fields directly.
UpdateObject uses the same PropertyChange structure that is sent as
part of the WaitForUpdatesEx response.  UpdateObject will also apply
the PropertyChange(s) to the local object, removing the need to set
fields directly.

- govc commands now use Client.Flag.WithCancel to catch SIGINT,
  allowing proper cleanup of collectors

- Add vcsim ListView support to ViewManager

Fixes vmware#922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants