Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of driver name #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamesClonk
Copy link

@JamesClonk JamesClonk commented Apr 26, 2023

Description

Adds new flag driver-name to main, to allow users to customize the driver and change its default from "named-disk.csi.cloud-director.vmware.com" to another value.

The intention is that this way there could be multiple instances/deployments of cloud-director-named-disk-csi-driver deployed on the same Kubernetes cluster but with different CSIDriver names (and storage classes), configured for multiple different VDC's which host Kubernetes nodes.

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

This change is Reviewable

@vmwclabot
Copy link
Member

@JamesClonk, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@JamesClonk, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@JamesClonk, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

In your address please include city and country.

@vmwclabot
Copy link
Member

@JamesClonk, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@JamesClonk, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants