-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Skip vmtoolsd and vgauthd status checking when they are upheld in Flatcar #548
Merged
keirazhang
merged 3 commits into
vmware:main
from
keirazhang:fix_flatcar_service_status
Feb 20, 2024
Merged
[Linux] Skip vmtoolsd and vgauthd status checking when they are upheld in Flatcar #548
keirazhang
merged 3 commits into
vmware:main
from
keirazhang:fix_flatcar_service_status
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re upheld Signed-off-by: Qi Zhang <[email protected]>
Test results:
|
123lzxm
reviewed
Feb 19, 2024
Signed-off-by: Qi Zhang <[email protected]>
123lzxm
previously approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Tomorrow9
reviewed
Feb 20, 2024
Signed-off-by: Qi Zhang <[email protected]>
Tomorrow9
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing Flatcar Stable 3760.2.0, we found that the default status of vmtoolsd.service and vgauthd.service were disabled, but they could start at boot. That is because they are started via a dependency in
/usr/lib/systemd/system/multi-user.target.d/open-vm-tools-sysext-upholds.conf. flatcar/Flatcar#1330 (comment) explains this change.
So in our test cases, we need to checking whether vmtoolsd and vgauthd are in upholds of systemd unit multi-user.target for Flatcar. If they are in upholds, we can ignore their service status, no matter they are enabled or disabled.