Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Skip vmtoolsd and vgauthd status checking when they are upheld in Flatcar #548

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

keirazhang
Copy link
Contributor

While testing Flatcar Stable 3760.2.0, we found that the default status of vmtoolsd.service and vgauthd.service were disabled, but they could start at boot. That is because they are started via a dependency in
/usr/lib/systemd/system/multi-user.target.d/open-vm-tools-sysext-upholds.conf. flatcar/Flatcar#1330 (comment) explains this change.

So in our test cases, we need to checking whether vmtoolsd and vgauthd are in upholds of systemd unit multi-user.target for Flatcar. If they are in upholds, we can ignore their service status, no matter they are enabled or disabled.

@keirazhang keirazhang added this to the 3.2 milestone Feb 19, 2024
@keirazhang
Copy link
Contributor Author

Test results:

VM information:
+------------------------------------------------------------------------------------------------------+
| Name                      | test_vm                                                                  |
+------------------------------------------------------------------------------------------------------+
| Guest OS Distribution     | Flatcar 3815.2.0 x86_64                                                  |
+------------------------------------------------------------------------------------------------------+
| IP                        | 
+------------------------------------------------------------------------------------------------------+
| GUI Installed             | False                                                                    |
+------------------------------------------------------------------------------------------------------+
| CloudInit Version         |                                                                          |
+------------------------------------------------------------------------------------------------------+
| Hardware Version          | vmx-20                                                                   |
+------------------------------------------------------------------------------------------------------+
| VMTools Version           | 12.3.5 (build-22544099)                                                  |
+------------------------------------------------------------------------------------------------------+
| Config Guest Id           | other3xLinux64Guest                                                      |
+------------------------------------------------------------------------------------------------------+
| GuestInfo Guest Id        | other6xLinux64Guest                                                      |
+------------------------------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Other 6.x or later Linux (64-bit)                                        |
+------------------------------------------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                                               |
+------------------------------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                                       |
|                           | bitness='64'                                                             |
|                           | buildNumber='2024-02-12-2039'                                            |
|                           | cpeString='cpe:2.3:o:flatcar-linux:flatcar_linux:3815.2.0:*:*:*:*:*:*:*' |
|                           | distroAddlVersion='3815.2.0'                                             |
|                           | distroName='Flatcar Container Linux by Kinvolk'                          |
|                           | distroVersion='3815.2.0'                                                 |
|                           | familyName='Linux'                                                       |
|                           | kernelVersion='6.1.77-flatcar'                                           |
|                           | prettyName='Flatcar Container Linux by Kinvolk 3815.2.0 (Oklo)'          |
+------------------------------------------------------------------------------------------------------+

Test Results (Total: 2, Passed: 2, Elapsed Time: 00:01:45)
+------------------------------------------------+
| ID | Name                 | Status | Exec Time |
+------------------------------------------------+
|  1 | ovt_verify_status    | Passed | 00:00:48  |
|  2 | vgauth_check_service | Passed | 00:00:38  |
+------------------------------------------------+

Signed-off-by: Qi Zhang <[email protected]>
123lzxm
123lzxm previously approved these changes Feb 20, 2024
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Signed-off-by: Qi Zhang <[email protected]>
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit 4af684e into vmware:main Feb 20, 2024
@keirazhang keirazhang deleted the fix_flatcar_service_status branch March 7, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants