Check VMware Tools version after OVA/OVF deployment without poweron

[ZouYuhua]

From John:
Can you please check to see if our testing of OVAs includes verification of vmdk that ddb.toolsVersion is set to 2147483647 if open-vm-tools is included? If we are not doing this then please add as a candidate new test. I think the check needs to be done without booting the VM to be valid.

Test result:

1. test with ubuntu 23.04 OVA:

2. test with photon 5.0 OVA

[keirazhang]

We already have a common task common/collect_ovf_vm_config.yml, in which ddb.toolsVersion is collected from vm_config.config.tools.toolsVersion.

- name: "Get VMware Tools info"
  ansible.builtin.set_fact:
    ovf_vm_vmtools_info: >-
      {{  
        ovf_vm_vmtools_info |
        combine({'Version': vm_config.config.tools.toolsVersion | default(''),
                 'Install Type': vm_config.config.tools.toolsInstallType | default(''),
                 'Upgrade Policy': vm_config.config.tools.toolsUpgradePolicy | default(''),
                 'Sync Time with Host': vm_config.config.tools.syncTimeWithHost | default('')})
      }}  

I think you can directly use it with some changes:

1. Move out included task vm_get_vm_info.yml from common/collect_ovf_vm_config.yml, and replace vars like vm_guest_id in common/collect_ovf_vm_config.yml with vm_config.config.guestId.
2. The moved out vm_get_vm_info.yml can be put after common/collect_ovf_vm_config.yml in linux/deploy_vm/deploy_vm_from_ova.yml and windows/deploy_vm/deploy_vm_from_ova.yml
3. Move the power on task common/vm_set_power_state.yml from deploy_vm_from_ova.yml into common/collect_ovf_vm_config.yml, and put it before vm_wait_vmtools_status.yml
4. In common/collect_ovf_vm_config.yml, it collected vmtools version twice: one from vm_config.config.tools.toolsVersion and the other one from guestinfo_vmtools_info. And the second one will overwrite the first one. Since we need to check ddb.toolsVersion before power-on, I suggest you save them with two different keys in ovf_vm_vmtools_info. For example, we can save the first one as 'Config Tools Version' and the second one as 'Guest Tools Version'.
5. The default ddb.toolsVersion is 2147483647, but OS vendor might change it to real tools version number in meta data. So you need to check it is either 2147483647 or same as guestinfo.vmtools.versionNumber get from vm_extra_config.

[keirazhang]

LGTM. Thanks!