🌱 Controller-runtime v0.19.0 & Controller-tools v0.16.1 #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbueringer , it's failing here when running It works once I upgrade controller-tools to v0.16. Does controller-runtime v0.19.0 somehow force a dependency on controller-tools v0.16+? |
github-actions
bot
added
size/L
akutz
changed the title
aruneshpa
approved these changes
Aug 20, 2024
It's not controller-runtime that does it, it's k8s.io/api v0.31.0 (xref: kubernetes-sigs/controller-tools#1000) |
|
lgtm +/- the linter findings |
We diff'ed all our roles in Cluster API when making the change in controller-gen and we have a lot :) (just for some additional confidence) |
akutz
force-pushed
the
feature/controller-runtime-v0.19.0
branch
2 times, most recently
from
aef8004 to
1322631
Compare
github-actions
bot
added
size/XL
akutz
commented
Aug 21, 2024
This patch updates VM Operator to Controller-Runtime v0.19.0 and Controller-Tools v0.16.1 as it is required to work with the new k8s.io dependency pulled in by Controller-Runtime. This patch also addresses a bunch of linting issues brought to light by stale linting caches on developer systems and on GitHub actions where part of the cache key is the sum of the go.mod file. Since the module file changed, it ran with a clean cache, revelealing the issues. Finally, this patch updates a few tests to set conditions' field LastTransitionTime to a non-empty value since that is now a required field.
akutz
force-pushed
the
feature/controller-runtime-v0.19.0
branch
from
1322631 to
4ebacd1
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates VM Operator to Controller-Runtime v0.19.0 and Controller-Tools v0.16.1.
Please note that this change apparently requires updating to controller-tools v0.16 as well, or else manifest generation fails per #675 (comment). To the VM Op team, please note one aspect of controller-tools v0.16 is deduplicating RBAC per kubernetes-sigs/controller-tools#937, hence the major diff to our
role.yamlfile.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
cc @sbueringer
Please add a release note if necessary: