Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15] hide restic deprecation warning for install with crd-only #8540

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8539, validate uploader types when o.CRDsOnly is set to false only since CRD installation doesn't rely on uploader types

@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 20, 2024
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 20, 2024 08:07
@kaovilai kaovilai merged commit b661ed7 into vmware-tanzu:release-1.15 Dec 20, 2024
43 checks passed
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.12%. Comparing base (4376a89) to head (11a2be6).
Report is 2 commits behind head on release-1.15.

Files with missing lines Patch % Lines
pkg/cmd/cli/install/install.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.15    #8540   +/-   ##
=============================================
  Coverage         59.12%   59.12%           
=============================================
  Files               367      367           
  Lines             39118    39118           
=============================================
  Hits              23130    23130           
  Misses            14520    14520           
  Partials           1468     1468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants