Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick-1.15] Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go #8505

Merged

Conversation

reasonerjt
Copy link
Contributor

@reasonerjt reasonerjt commented Dec 11, 2024

Please indicate you've done the following:

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (f499025) to head (5ddb319).
Report is 2 commits behind head on release-1.15.

Files with missing lines Patch % Lines
pkg/repository/config/aws.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #8505      +/-   ##
================================================
- Coverage         59.00%   58.97%   -0.04%     
================================================
  Files               367      367              
  Lines             38903    38910       +7     
================================================
- Hits              22955    22947       -8     
- Misses            14485    14499      +14     
- Partials           1463     1464       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reasonerjt reasonerjt force-pushed the repo-aws-region-hint-1.15 branch from b756850 to 5ddb319 Compare December 11, 2024 07:37
@reasonerjt reasonerjt merged commit bda3ec1 into vmware-tanzu:release-1.15 Dec 11, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants