Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CherryPick][1.14] Merge pull request #7983 from anshulahuja98/snapshotsync #8004

Merged

Conversation

anshulahuja98
Copy link
Collaborator

Reset VolumeSnapshotRef in Backup Sync Flow
Fixes #7978
Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot requested review from Lyndon-Li and reasonerjt July 12, 2024 04:46
@anshulahuja98 anshulahuja98 changed the title [CherryPick] Merge pull request #7983 from anshulahuja98/snapshotsync [CherryPick][1.14] Merge pull request #7983 from anshulahuja98/snapshotsync Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.14@80a5b51). Learn more about missing BASE report.

Files Patch % Lines
pkg/controller/backup_sync_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14    #8004   +/-   ##
===============================================
  Coverage                ?   58.79%           
===============================================
  Files                   ?      346           
  Lines                   ?    28823           
  Branches                ?        0           
===============================================
  Hits                    ?    16947           
  Misses                  ?    10445           
  Partials                ?     1431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 12, 2024
@blackpiglet
Copy link
Contributor

One comment.
It seems we should use this commit 4a6a362 instead of the merge commit.

@anshulahuja98 anshulahuja98 force-pushed the vsc-cherrypick-1.14-3 branch from 652d9bc to 5c1d80f Compare July 12, 2024 06:05
@anshulahuja98 anshulahuja98 merged commit 1c7412d into vmware-tanzu:release-1.14 Jul 12, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants