-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testifylint: enable compares rule #7671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
Apr 15, 2024
kaovilai
approved these changes
Apr 16, 2024
kaovilai
approved these changes
Apr 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7671 +/- ##
=======================================
Coverage 58.67% 58.67%
=======================================
Files 345 345
Lines 28739 28739
=======================================
Hits 16862 16862
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
blackpiglet
previously approved these changes
May 6, 2024
Signed-off-by: Matthieu MOREL <[email protected]>
kaovilai
approved these changes
May 20, 2024
sseago
approved these changes
May 20, 2024
shubham-pampattiwar
approved these changes
May 20, 2024
ccoVeille
reviewed
May 26, 2024
ccoVeille
reviewed
May 26, 2024
blackpiglet
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has-unit-tests
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
testifylint: enable compares rule
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.