Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gvr Group and Version field missing in KindFor method #7530

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

zhouhaoA1
Copy link

@zhouhaoA1 zhouhaoA1 commented Mar 15, 2024

Thank you for contributing to Velero!

Please add a summary of your change

fix gvr Group and Version field missing in KindFor method of package discovery

Does your change fix a particular issue?

Fixes #(issue)
#7529

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@zhouhaoA1
Copy link
Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Mar 15, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 61.64%. Comparing base (b3a53ee) to head (7ce35ec).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/discovery/helper.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7530      +/-   ##
==========================================
- Coverage   61.65%   61.64%   -0.01%     
==========================================
  Files         263      263              
  Lines       28680    28682       +2     
==========================================
  Hits        17682    17682              
- Misses       9753     9755       +2     
  Partials     1245     1245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet changed the title Issue 7529: fix gvr Group and Version field missing in KindFor Fix gvr Group and Version field missing in KindFor Mar 19, 2024
@blackpiglet blackpiglet changed the title Fix gvr Group and Version field missing in KindFor Fix gvr Group and Version field missing in KindFor method Mar 19, 2024
@qiuming-best qiuming-best merged commit 922653e into vmware-tanzu:main Mar 19, 2024
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants