-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary support for s390x #7505
base: main
Are you sure you want to change the base?
Binary support for s390x #7505
Conversation
Signed-off-by: Pandurang Alias Aradhya Khandeparker <[email protected]>
0dfd4d1
to
7d38976
Compare
IMHO, given we don't have resources or bandwidth to verify on zLinux, shall we let this remain downstream? |
@reasonerjt If access to Please let us know what is required for It will be great for |
Are we open to unsupported binary release (at your own risk)? |
I think we should try to maintain fidelity with other archs - at a minimum |
How do you propose velero obtain the infra to test this? Running in github actions emulated would be very slow. |
This is a real |
If it can be added as a github actions runner maybe. That way is not another separate test pipeline.. only maintainers can add new hosted runners to the repo tho. |
It's not just access, but lack of maintainers bandwidth to prioritize signing up for a new account and hooking it up to CI. If you have a fork that produces binaries I think it'll be an easier pill to swallow for maintainers to link to your fork for an unofficial s390x binary. Tho personally I think unverified binary is ok upstream. |
Looks like that added build support for ppc64le but explicitly disabled publishing docker images. So I think this means the testing infra does not test on this env, but it allows users to build easily from a checkout. I'm not 100% sure though. |
|
See if this would work for you in the meantime.
you can see which tags are available at https://catalog.redhat.com/software/containers/oadp/oadp-velero-rhel9/64510133c1647dae8134a158 |
@kaovilai Yes - that works. However, this effort is to ensure we have artifacts available here as well. |
Thank you for contributing to Velero!
Signed-off-by: Pandurang Alias Aradhya Khandeparker [email protected]
Please add a summary of your change
This PR aims to add s390x support to Velero binary.
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.