-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --skip-immediately
to schedule CLI/API, and related to server, install commands
#7169
Merged
ywk253100
merged 4 commits into
vmware-tanzu:main
from
kaovilai:schedule-skip-immediately
Dec 8, 2023
Merged
Add --skip-immediately
to schedule CLI/API, and related to server, install commands
#7169
ywk253100
merged 4 commits into
vmware-tanzu:main
from
kaovilai:schedule-skip-immediately
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
schedule-skip-immediately
branch
from
November 30, 2023 17:54
8b507f5
to
4dd1600
Compare
kaovilai
changed the title
schedule skip immediately
Enable schedule immediately skipping
Nov 30, 2023
kaovilai
force-pushed
the
schedule-skip-immediately
branch
7 times, most recently
from
December 1, 2023 02:39
e536748
to
3b46f53
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7169 +/- ##
==========================================
+ Coverage 61.65% 61.68% +0.03%
==========================================
Files 262 262
Lines 28351 28384 +33
==========================================
+ Hits 17480 17510 +30
- Misses 9635 9637 +2
- Partials 1236 1237 +1 ☔ View full report in Codecov by Sentry. |
kaovilai
changed the title
Enable schedule immediately skipping
Add Dec 1, 2023
--skip-immediately
to schedule CLI commands
kaovilai
force-pushed
the
schedule-skip-immediately
branch
from
December 1, 2023 04:12
3b46f53
to
70e1b0c
Compare
kaovilai
force-pushed
the
schedule-skip-immediately
branch
3 times, most recently
from
December 1, 2023 05:08
1fb1484
to
8cee7ae
Compare
3 tasks
kaovilai
force-pushed
the
schedule-skip-immediately
branch
3 times, most recently
from
December 1, 2023 16:01
50ac632
to
2f05914
Compare
What happened here?
|
kaovilai
changed the title
Add
Add Dec 1, 2023
--skip-immediately
to schedule CLI commands--skip-immediately
to schedule CLI/API, and related to server, install commands
kaovilai
force-pushed
the
schedule-skip-immediately
branch
from
December 1, 2023 20:43
2f05914
to
059b613
Compare
ywk253100
reviewed
Dec 5, 2023
ywk253100
reviewed
Dec 5, 2023
kaovilai
force-pushed
the
schedule-skip-immediately
branch
from
December 6, 2023 07:30
0f6feec
to
6ff6023
Compare
ywk253100
previously approved these changes
Dec 6, 2023
Thanks for the review! |
@kaovilai Could you please rebase this PR? |
Yup |
Signed-off-by: Tiger Kaovilai <[email protected]> switch from "unpause triggers" to "skip immediately" for clarity Signed-off-by: Tiger Kaovilai <[email protected]> Apply suggestions from code review Signed-off-by: Tiger Kaovilai <[email protected]> Uncomment velero server option Signed-off-by: Tiger Kaovilai <[email protected]> Backup will also be triggered at the next cron schedule. Signed-off-by: Tiger Kaovilai <[email protected]> Clarify: unpauseTriggers trigger based from lastBackup timestamp, CRD default blocks server flags Signed-off-by: Tiger Kaovilai <[email protected]> `velero schedule unpause schedule-1` will check `.spec.UnpauseTriggers` Signed-off-by: Tiger Kaovilai <[email protected]> Add `LastUnpaused` to ScheduleStatus Signed-off-by: Tiger Kaovilai <[email protected]> Add `velero install` Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
schedule-skip-immediately
branch
from
December 8, 2023 02:12
0792f77
to
eaba99b
Compare
Lyndon-Li
approved these changes
Dec 8, 2023
ywk253100
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on design at #6829
Design commit should go away when rebased after design merged.
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6517
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.