Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip-immediately to schedule CLI/API, and related to server, install commands #7169

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 30, 2023

Based on design at #6829

Design commit should go away when rebased after design merged.

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6517

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai force-pushed the schedule-skip-immediately branch from 8b507f5 to 4dd1600 Compare November 30, 2023 17:54
@kaovilai kaovilai changed the title schedule skip immediately Enable schedule immediately skipping Nov 30, 2023
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch 7 times, most recently from e536748 to 3b46f53 Compare December 1, 2023 02:39
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4070934) 61.65% compared to head (eaba99b) 61.68%.

Files Patch % Lines
pkg/install/deployment.go 57.14% 2 Missing and 1 partial ⚠️
pkg/cmd/server/server.go 66.66% 1 Missing ⚠️
pkg/controller/schedule_controller.go 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7169      +/-   ##
==========================================
+ Coverage   61.65%   61.68%   +0.03%     
==========================================
  Files         262      262              
  Lines       28351    28384      +33     
==========================================
+ Hits        17480    17510      +30     
- Misses       9635     9637       +2     
- Partials     1236     1237       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaovilai kaovilai changed the title Enable schedule immediately skipping Add --skip-immediately to schedule CLI commands Dec 1, 2023
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch from 3b46f53 to 70e1b0c Compare December 1, 2023 04:12
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch 3 times, most recently from 1fb1484 to 8cee7ae Compare December 1, 2023 05:08
@kaovilai kaovilai marked this pull request as ready for review December 1, 2023 05:21
@github-actions github-actions bot requested review from Lyndon-Li and sseago December 1, 2023 05:21
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch 3 times, most recently from 50ac632 to 2f05914 Compare December 1, 2023 16:01
@kaovilai
Copy link
Member Author

kaovilai commented Dec 1, 2023

What happened here?

[2023-12-01T16:08:23.706Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2023-12-01T16:08:23.706Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
    at main (/snapshot/repo/dist/src/index.js)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2023-12-01T16:08:23.706Z] ['verbose'] End of uploader: 1062 milliseconds
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

@kaovilai kaovilai changed the title Add --skip-immediately to schedule CLI commands Add --skip-immediately to schedule CLI/API, and related to server, install commands Dec 1, 2023
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch from 2f05914 to 059b613 Compare December 1, 2023 20:43
@reasonerjt reasonerjt added this to the v1.13 milestone Dec 4, 2023
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch from 0f6feec to 6ff6023 Compare December 6, 2023 07:30
@kaovilai kaovilai requested a review from ywk253100 December 6, 2023 07:32
ywk253100
ywk253100 previously approved these changes Dec 6, 2023
@kaovilai
Copy link
Member Author

kaovilai commented Dec 6, 2023

Thanks for the review!

@reasonerjt
Copy link
Contributor

@kaovilai Could you please rebase this PR?

@kaovilai
Copy link
Member Author

kaovilai commented Dec 8, 2023

Yup

Signed-off-by: Tiger Kaovilai <[email protected]>

switch from "unpause triggers" to "skip immediately" for clarity

Signed-off-by: Tiger Kaovilai <[email protected]>

Apply suggestions from code review

Signed-off-by: Tiger Kaovilai <[email protected]>

Uncomment velero server option

Signed-off-by: Tiger Kaovilai <[email protected]>

Backup will also be triggered at the next cron schedule.

Signed-off-by: Tiger Kaovilai <[email protected]>

Clarify: unpauseTriggers trigger based from lastBackup timestamp,  CRD default blocks server flags

Signed-off-by: Tiger Kaovilai <[email protected]>

`velero schedule unpause schedule-1` will check `.spec.UnpauseTriggers`

Signed-off-by: Tiger Kaovilai <[email protected]>

Add `LastUnpaused` to ScheduleStatus

Signed-off-by: Tiger Kaovilai <[email protected]>

Add `velero install`

Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the schedule-skip-immediately branch from 0792f77 to eaba99b Compare December 8, 2023 02:12
@ywk253100 ywk253100 merged commit fa73bcd into vmware-tanzu:main Dec 8, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup gets triggered when schedule unpaused
4 participants