Track the skipped PV when SnapshotVolumes set as false #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
requested review from
ywk253100 and
Lyndon-Li
and removed request for
qiuming-best
reasonerjt
force-pushed
the
track-skipped-SnapshotVolumes-false
branch
from
462e615 to
9b7a5c2
Compare
This commit makes sure if a PV is not taken snapshot b/c the flag SnapshotVolumes is set to false in a backup CR, the PV is also also tracked as skipped in the tracker. Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt
force-pushed
the
track-skipped-SnapshotVolumes-false
branch
from
9b7a5c2 to
b759877
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7152 +/- ##
==========================================
+ Coverage 61.69% 61.81% +0.11%
==========================================
Files 258 259 +1
Lines 27644 27865 +221
==========================================
+ Hits 17055 17224 +169
- Misses 9395 9438 +43
- Partials 1194 1203 +9 ☔ View full report in Codecov by Sentry. |
Lyndon-Li
approved these changes
Nov 29, 2023
blackpiglet
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure if a PV is not taken snapshot b/c the flag SnapshotVolumes is set to false in a backup CR, the PV is also tracked as skipped in the tracker.
Fixes #5834
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.