Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include plugin name in the error message by operations #7115

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

reasonerjt
Copy link
Contributor

fixes #6512

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai
Copy link
Member

--- FAIL: TestBackupOperationsReconcile (0.00s)
    --- FAIL: TestBackupOperationsReconcile/WaitingForPluginOperations_backup_with_completed_failed_operations_is_FinalizingPartiallyFailed (0.00s)
panic: 
assert: mock: I don't know what to return because the method call was unexpected.
	Either do Mock.On("Name").Return(...) first, or remove the Name() call.
	This method was unexpected:
		Name()
		
	at: [/github.com/vmware-tanzu/velero/pkg/plugin/velero/mocks/backupitemaction/v2/BackupItemAction.go:119 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller.go:386 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller.go:346 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller.go:177 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller_test.go:298] [recovered]
	panic: 
assert: mock: I don't know what to return because the method call was unexpected.
	Either do Mock.On("Name").Return(...) first, or remove the Name() call.
	This method was unexpected:
		Name()
		
	at: [/github.com/vmware-tanzu/velero/pkg/plugin/velero/mocks/backupitemaction/v2/BackupItemAction.go:119 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller.go:386 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller.go:346 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller.go:177 /github.com/vmware-tanzu/velero/pkg/controller/backup_operations_controller_test.go:298]

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9b5678f) 61.24% compared to head (ca57756) 61.20%.
Report is 19 commits behind head on main.

Files Patch % Lines
pkg/controller/backup_operations_controller.go 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7115      +/-   ##
==========================================
- Coverage   61.24%   61.20%   -0.04%     
==========================================
  Files         257      258       +1     
  Lines       27273    27362      +89     
==========================================
+ Hits        16702    16747      +45     
- Misses       9388     9430      +42     
- Partials     1183     1185       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit e3fb948 into vmware-tanzu:main Nov 20, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIAv2 error log should say which plugin it came from (when empty).
4 participants