Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Truncate the credential file to avoid the change of secret content messing it up #7072

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ywk253100
Copy link
Contributor

Truncate the credential file to avoid the change of secret content messing it up

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

…ssing it up

Truncate the credential file to avoid the change of secret content messing it up

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@ywk253100 ywk253100 requested review from reasonerjt and qiuming-best and removed request for shubham-pampattiwar and anshulahuja98 November 8, 2023 01:35
@ywk253100 ywk253100 changed the title Truncate the credential file to avoid the change of secret content messing it up [cherry-pick]Truncate the credential file to avoid the change of secret content messing it up Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #7072 (5a10f90) into main (866fbb5) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7072      +/-   ##
==========================================
- Coverage   61.02%   60.99%   -0.03%     
==========================================
  Files         255      255              
  Lines       27040    27040              
==========================================
- Hits        16500    16492       -8     
- Misses       9361     9368       +7     
- Partials     1179     1180       +1     
Files Coverage Δ
internal/credentials/file_store.go 60.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qiuming-best qiuming-best merged commit 5f7e16b into vmware-tanzu:main Nov 8, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants