Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.12: restore: Use warning when Create IsAlreadyExist and Get error (#7004) #7054

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 2, 2023

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago
Copy link
Collaborator

sseago commented Nov 2, 2023

@kaovilai you need to rename the changelog file to match the CP PR number.

@kaovilai kaovilai force-pushed the warnOnCreateAlreadyExistsGetError-release-1.12 branch from 48e35fa to 7e35fd3 Compare November 2, 2023 20:05
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #7054 (7e35fd3) into release-1.12 (482ec13) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@               Coverage Diff                @@
##           release-1.12    #7054      +/-   ##
================================================
- Coverage         60.46%   60.46%   -0.01%     
================================================
  Files               247      247              
  Lines             26407    26406       -1     
================================================
- Hits              15967    15966       -1     
  Misses             9318     9318              
  Partials           1122     1122              
Files Coverage Δ
pkg/restore/restore.go 65.91% <60.00%> (-0.03%) ⬇️

@Lyndon-Li Lyndon-Li merged commit 1264c43 into vmware-tanzu:release-1.12 Nov 6, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants