-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit PVC block mode logic to non-Windows platform #6986
Limit PVC block mode logic to non-Windows platform #6986
Conversation
168c18a
to
49a5c50
Compare
0f179f3
to
2586f1e
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.12 #6986 +/- ##
================================================
- Coverage 60.47% 60.44% -0.04%
================================================
Files 247 247
Lines 26398 26398
================================================
- Hits 15965 15957 -8
- Misses 9312 9319 +7
- Partials 1121 1122 +1
|
@dzaninovic |
PVC block mode backup and restore introduced some OS specific system calls. Those calls are not available for Windows, so add both non Windows version and Windows version code, and return error for block mode on the Windows platform. Signed-off-by: Xun Jiang <[email protected]>
2586f1e
to
3034cdb
Compare
@blackpiglet, fix looks good to me. |
@Lyndon-Li should we add this to public docs? |
@anshulahuja98 |
I think it is about adding a limitation statement for Windows, is that what you mean? @anshulahuja98 |
Yes it was for windows limitation. |
@Lyndon-Li @anshulahuja98 |
Even the changelog / pr title of current pr is misleading |
@anshulahuja98 @Lyndon-Li |
Release v1.12.rc.1 failed with the Windows binary build. The error message is:
The reason is that PVC block mode backup and restore introduced some OS-specific system calls.
Those calls are not available for Windows, so add both non-Windows version and Windows version code and return an error for block mode on the Windows platform.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.