Issue 6964: get volume size from source PVC if it is invalid in VS #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
force-pushed
the
issue-fix-6964
branch
from
a8cafe9 to
355230e
Compare
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
issue-fix-6964
branch
from
355230e to
329c128
Compare
blackpiglet
approved these changes
Oct 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #6976 +/- ##
==========================================
+ Coverage 60.78% 61.05% +0.26%
==========================================
Files 250 251 +1
Lines 26629 26845 +216
==========================================
+ Hits 16187 16389 +202
- Misses 9293 9303 +10
- Partials 1149 1153 +4
|
qiuming-best
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a valid case that the
Status.RestoreSizefield in VolumeSnapshot is not set, if so, get the volume size from the source PVC to create the backup PVC