Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6933: Import auth provider plugins #6947

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

0x113
Copy link
Contributor

@0x113 0x113 commented Oct 12, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Added imports for auth provider plugins, which were deleted by 180cc4e

Does your change fix a particular issue?

Fixes #6933

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@ywk253100
Copy link
Contributor

@0x113 Could you sign-off the commit to pass the DCO checking?

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #6947 (265d285) into main (84734f1) will increase coverage by 0.36%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6947      +/-   ##
==========================================
+ Coverage   60.67%   61.03%   +0.36%     
==========================================
  Files         250      251       +1     
  Lines       26515    26837     +322     
==========================================
+ Hits        16088    16381     +293     
- Misses       9283     9303      +20     
- Partials     1144     1153       +9     

see 16 files with indirect coverage changes

@0x113 0x113 force-pushed the SGLAB-CLOUDCASA-oidc-auth branch from decde39 to 46ec0de Compare October 16, 2023 08:03
@0x113
Copy link
Contributor Author

0x113 commented Oct 16, 2023

@ywk253100 I just signed it off. Thank you!

ywk253100
ywk253100 previously approved these changes Oct 18, 2023
blackpiglet
blackpiglet previously approved these changes Oct 18, 2023
Signed-off-by: Sebastian Glab <[email protected]>
@0x113 0x113 dismissed stale reviews from blackpiglet and ywk253100 via 265d285 October 18, 2023 06:53
@0x113 0x113 force-pushed the SGLAB-CLOUDCASA-oidc-auth branch from 46ec0de to 265d285 Compare October 18, 2023 06:53
@0x113 0x113 requested a review from blackpiglet October 18, 2023 06:55
@ywk253100 ywk253100 merged commit 19f38f9 into vmware-tanzu:main Oct 18, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Velero v1.12.0 has no auth provider found for name "oidc"
3 participants