-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6933: Import auth provider plugins #6947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x113
force-pushed
the
SGLAB-CLOUDCASA-oidc-auth
branch
from
October 12, 2023 13:40
d1be424
to
decde39
Compare
@0x113 Could you sign-off the commit to pass the DCO checking? |
Codecov Report
@@ Coverage Diff @@
## main #6947 +/- ##
==========================================
+ Coverage 60.67% 61.03% +0.36%
==========================================
Files 250 251 +1
Lines 26515 26837 +322
==========================================
+ Hits 16088 16381 +293
- Misses 9283 9303 +20
- Partials 1144 1153 +9 |
0x113
force-pushed
the
SGLAB-CLOUDCASA-oidc-auth
branch
from
October 16, 2023 08:03
decde39
to
46ec0de
Compare
@ywk253100 I just signed it off. Thank you! |
ywk253100
previously approved these changes
Oct 18, 2023
blackpiglet
previously approved these changes
Oct 18, 2023
blackpiglet
reviewed
Oct 18, 2023
blackpiglet
reviewed
Oct 18, 2023
Signed-off-by: Sebastian Glab <[email protected]>
0x113
force-pushed
the
SGLAB-CLOUDCASA-oidc-auth
branch
from
October 18, 2023 06:53
46ec0de
to
265d285
Compare
blackpiglet
approved these changes
Oct 18, 2023
ywk253100
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Added imports for auth provider plugins, which were deleted by 180cc4e
Does your change fix a particular issue?
Fixes #6933
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.