Code clean for backup cmd client. #6750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
Codecov Report
@@ Coverage Diff @@
## main #6750 +/- ##
=======================================
Coverage 60.66% 60.67%
=======================================
Files 249 249
Lines 26480 26476 -4
=======================================
- Hits 16065 16064 -1
+ Misses 9270 9268 -2
+ Partials 1145 1144 -1
|
qiuming-best
previously approved these changes
Sep 11, 2023
blackpiglet
added
kind/changelog-not-required
blackpiglet
reviewed
Sep 12, 2023
yanggangtony
force-pushed
the
backup-cmd-optimize
branch
from
a13fb1e to
817fff0
Compare
yanggangtony
force-pushed
the
backup-cmd-optimize
branch
3 times, most recently
from
1d185bf to
b272542
Compare
blackpiglet
previously approved these changes
Sep 21, 2023
yanggangtony
force-pushed
the
backup-cmd-optimize
branch
from
b272542 to
aadb51b
Compare
blackpiglet
approved these changes
Sep 21, 2023
|
modify the code , let the pr small and good to review. |
blackpiglet
previously approved these changes
Sep 28, 2023
sseago
previously approved these changes
Sep 28, 2023
|
@yanggangtony Looks like there's a conflict w/ recently-merged code to main. This PR needs rebase now. |
Signed-off-by: yanggang <[email protected]>
yanggangtony
dismissed stale reviews from sseago and blackpiglet
via
55a88a4
yanggangtony
force-pushed
the
backup-cmd-optimize
branch
from
aadb51b to
55a88a4
Compare
@sseago Rebased. Thanks. |
blackpiglet
approved these changes
Sep 29, 2023
sseago
approved these changes
Sep 29, 2023
kaovilai
pushed a commit
to kaovilai/velero
that referenced
this pull request
Oct 2, 2023
Signed-off-by: yanggang <[email protected]>
kaovilai
pushed a commit
to kaovilai/velero
that referenced
this pull request
Oct 2, 2023
Signed-off-by: yanggang <[email protected]>
blackpiglet
pushed a commit
to blackpiglet/velero
that referenced
this pull request
Oct 3, 2023
Signed-off-by: yanggang <[email protected]>
blackpiglet
pushed a commit
to blackpiglet/velero
that referenced
this pull request
Oct 3, 2023
Address some code spell check errors. Signed-off-by: yanggang <[email protected]> Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
pushed a commit
to blackpiglet/velero
that referenced
this pull request
Oct 3, 2023
Address some code spell check errors. Signed-off-by: Xun Jiang <[email protected]>
3 tasks
blackpiglet
added a commit
that referenced
this pull request
Oct 8, 2023
[cherry-pick][release-1.12]Code clean for backup cmd client. (#6750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Code clean for backup cmd client.
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.