Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.12: On restore, delete Kubernetes 1.27 job controller uid label #6713

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Aug 28, 2023

  • Handle 1.27 k8s job label changes
  • changelog

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6711

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai force-pushed the jobs-label-k8s1.27-velero1.12 branch from 90a1c36 to 8c89507 Compare August 28, 2023 14:50
@kaovilai kaovilai changed the title jobs label k8s1.27 velero1.12 release-1.12: jobs label k8s1.27 velero1.12 Aug 28, 2023
@kaovilai kaovilai changed the title release-1.12: jobs label k8s1.27 velero1.12 release-1.12: On restore, delete Kubernetes 1.27 job controller uid label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #6713 (aba64ba) into release-1.12 (9d5dd8e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release-1.12    #6713   +/-   ##
=============================================
  Coverage         60.47%   60.47%           
=============================================
  Files               244      244           
  Lines             26072    26074    +2     
=============================================
+ Hits              15766    15768    +2     
  Misses             9199     9199           
  Partials           1107     1107           
Files Coverage Δ
pkg/restore/job_action.go 56.52% <100.00%> (+4.14%) ⬆️

Copy link
Collaborator

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaovilai Can you please rebase this PR ?

@kaovilai kaovilai force-pushed the jobs-label-k8s1.27-velero1.12 branch from d21441a to dcf5b2a Compare September 27, 2023 16:52
@kaovilai kaovilai force-pushed the jobs-label-k8s1.27-velero1.12 branch from dcf5b2a to 87dff77 Compare September 29, 2023 16:22
@kaovilai kaovilai force-pushed the jobs-label-k8s1.27-velero1.12 branch from 87dff77 to aba64ba Compare September 29, 2023 16:27
@shubham-pampattiwar shubham-pampattiwar merged commit 554403d into vmware-tanzu:release-1.12 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants