-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add label selector in Resource Modifiers #6704
Merged
anshulahuja98
merged 4 commits into
vmware-tanzu:main
from
27149chen:add-label-selector-in-resource-modifier
Aug 31, 2023
Merged
add label selector in Resource Modifiers #6704
anshulahuja98
merged 4 commits into
vmware-tanzu:main
from
27149chen:add-label-selector-in-resource-modifier
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lou <[email protected]>
27149chen
force-pushed
the
add-label-selector-in-resource-modifier
branch
from
August 25, 2023 10:47
6431cc0
to
f05b024
Compare
Codecov Report
@@ Coverage Diff @@
## main #6704 +/- ##
==========================================
- Coverage 60.33% 60.32% -0.01%
==========================================
Files 242 242
Lines 25982 25986 +4
==========================================
+ Hits 15675 15676 +1
- Misses 9203 9205 +2
- Partials 1104 1105 +1
|
Signed-off-by: lou <[email protected]>
anshulahuja98
requested changes
Aug 28, 2023
Signed-off-by: lou <[email protected]>
anshulahuja98
previously approved these changes
Aug 28, 2023
CC @reasonerjt, we need to put this in 1.12 release branch, do you folks generally handle the cherry pick of such changes to release branch, or can I help in any way here? |
ywk253100
reviewed
Aug 31, 2023
Signed-off-by: lou <[email protected]>
ywk253100
approved these changes
Aug 31, 2023
anshulahuja98
approved these changes
Aug 31, 2023
anshulahuja98
pushed a commit
to anshulahuja98/velero
that referenced
this pull request
Aug 31, 2023
* add label selector in resource modifier Signed-off-by: lou <[email protected]> * add ut Signed-off-by: lou <[email protected]> * update after review Signed-off-by: lou <[email protected]> * update after review Signed-off-by: lou <[email protected]> --------- Signed-off-by: lou <[email protected]>
anshulahuja98
pushed a commit
to anshulahuja98/velero
that referenced
this pull request
Aug 31, 2023
* add label selector in resource modifier Signed-off-by: lou <[email protected]> * add ut Signed-off-by: lou <[email protected]> * update after review Signed-off-by: lou <[email protected]> * update after review Signed-off-by: lou <[email protected]> --------- Signed-off-by: lou <[email protected]> Signed-off-by: Anshul Ahuja <[email protected]>
reasonerjt
pushed a commit
to reasonerjt/velero
that referenced
this pull request
Aug 31, 2023
* add label selector in resource modifier Signed-off-by: lou <[email protected]> * add ut Signed-off-by: lou <[email protected]> * update after review Signed-off-by: lou <[email protected]> * update after review Signed-off-by: lou <[email protected]> --------- Signed-off-by: lou <[email protected]>
reasonerjt
added a commit
that referenced
this pull request
Aug 31, 2023
[1.12] Cherry Pick - add label selector in Resource Modifiers (#6704)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
This pr made some improvements in Resource Modifiers:
Does your change fix a particular issue?
N/A
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.