Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetS3Credentials pass profile from config to NewSharedCredentials #6565

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

kaovilai
Copy link
Member

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai force-pushed the s3profilefix-1.10 branch from 67f7353 to a52b149 Compare July 31, 2023 14:19
@codecov-commenter
Copy link

Codecov Report

Merging #6565 (9b934f0) into release-1.10 (fed41f5) will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           release-1.10    #6565   +/-   ##
=============================================
  Coverage         40.67%   40.67%           
=============================================
  Files               244      244           
  Lines             21068    21068           
=============================================
  Hits               8570     8570           
  Misses            11866    11866           
  Partials            632      632           
Files Changed Coverage Δ
pkg/repository/config/aws.go 24.39% <0.00%> (ø)

@blackpiglet blackpiglet merged commit 241eded into vmware-tanzu:release-1.10 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants