Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenStack CSI drivers topology keys #6488

Merged

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jul 12, 2023

This is a backport of the #6464

Please add a summary of your change

The change adds support for the OpenStack CSI drivers topology keys:

Does your change fix a particular issue?

Fixes #6440

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kayrus kayrus force-pushed the openstack-cis-zone-labels-1.11 branch from f523981 to a1e08f4 Compare July 12, 2023 20:33
@Lyndon-Li Lyndon-Li requested a review from blackpiglet July 13, 2023 01:40
@blackpiglet
Copy link
Contributor

AWS and Azure plugin may also needs this change.

@blackpiglet blackpiglet merged commit 6862fb8 into vmware-tanzu:release-1.11 Jul 14, 2023
@kayrus kayrus deleted the openstack-cis-zone-labels-1.11 branch July 14, 2023 09:08
@kayrus
Copy link
Contributor Author

kayrus commented Jul 14, 2023

@blackpiglet I wonder why, since they're already supported.

@blackpiglet
Copy link
Contributor

I made a mistake. I thought this is plugin-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants