Enhance code for issue 6297 #6326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6326 +/- ##
==========================================
+ Coverage 40.97% 42.94% +1.96%
==========================================
Files 255 222 -33
Lines 23833 22664 -1169
==========================================
- Hits 9766 9733 -33
+ Misses 13305 12168 -1137
- Partials 762 763 +1
|
reasonerjt
reviewed
May 31, 2023
pkg/repository/config/aws.go
Outdated
| if requestErrs == nil { | ||
| return "", errors.New("unable to determine bucket's region") | ||
| } else { | ||
| return "", goerr.Join(requestErrs...) |
There was a problem hiding this comment.
would be helpful to make the error more friendly like appending the bucket to the error message,
for each request error, append the regionhint <- not sure if this is helpful...
|
Please update the title of the PR and commit since this will not fix the particular issue, but only helps debugging the problem. |
danfengliu
previously approved these changes
May 31, 2023
Signed-off-by: Lyndon-Li <[email protected]>
danfengliu
approved these changes
May 31, 2023
reasonerjt
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the code because of #6297, the return value of
GetBucketRegionis not recorded, as a result, when it fails, we have no way to get the cause.