Include namespace resource needed by namespaced-scope resource in backup #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
has-e2e-tests
has-unit-tests
Website
github-actions
bot
removed
Website
ywk253100
reviewed
May 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #6320 +/- ##
==========================================
+ Coverage 40.97% 43.01% +2.03%
==========================================
Files 255 222 -33
Lines 23830 22704 -1126
==========================================
+ Hits 9764 9765 +1
+ Misses 13304 12174 -1130
- Partials 762 765 +3
|
blackpiglet
commented
Jun 1, 2023
blackpiglet
force-pushed
the
6302-fix
branch
4 times, most recently
from
328c88f to
43bc608
Compare
For some use cases, namespaced-scope resources are inluded into backup, but the namespaces are not included due to filters setting. To do this, removing label selector filter from namespace resource. Namespace resource only honor namespace exclude/include filters. Signed-off-by: Xun Jiang <[email protected]>
sseago
approved these changes
Jun 1, 2023
sseago
approved these changes
Jun 1, 2023
shubham-pampattiwar
approved these changes
Jun 1, 2023
ywk253100
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
For some use cases, namespaced-scope resources are inluded into backup, but the namespaces are not included due to filters setting. To do this, removing label selector filter from namespace resource. Namespace resource only honor namespace exclude/include filters.
Does your change fix a particular issue?
Fixes #6302
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.