Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.11] Fix issue 6182 #6189

Merged
merged 1 commit into from
Apr 26, 2023
Merged

[1.11] Fix issue 6182 #6189

merged 1 commit into from
Apr 26, 2023

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #6182. If pod is not running, don't treat it as an error, let it go and leave a warning.

@Lyndon-Li
Fix issue 6182
d6755f7 
Signed-off-by: Lyndon-Li <[email protected]>
@qiuming-best qiuming-best merged commit dc0a712 into vmware-tanzu:release-1.11 Apr 26, 2023
@SSvilen
Copy link

SSvilen commented May 10, 2023

@Lyndon-Li it seems that this did not make it in 1.11.0. In which patch version will this change be present?

@Lyndon-Li
Copy link
Contributor Author

@SSvilen It is not in 1.11.0, if you want to use 1.11, you need to wait for 1.11.1; otherwise, you can use 1.10.3 where the issue fix is included.

@SSvilen
Copy link

SSvilen commented May 22, 2023 •
edited
Loading

@Lyndon-Li ok thanks. Do you have an estimate when 1.11.1 will be available?

@kaovilai kaovilai mentioned this pull request Jul 7, 2023
Closed
3 tasks
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this pull request Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
0a52289 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai mentioned this pull request Jul 12, 2023
Closed
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this pull request Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
c09f232 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this pull request Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
fd59ba3 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this pull request Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
f048be7 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>

remove pod backup plugin from main.go
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this pull request Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
a7fa408 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>

Remove non-working code for backing up completed build pods

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>

remove pod backup plugin from main.go

Signed-off-by: Tiger Kaovilai <[email protected]>
openshift-merge-robot pushed a commit to openshift/openshift-velero-plugin that referenced this pull request Aug 22, 2023
@kaovilai
OADP-1057: AWS STS Creds support for internal image backup (#199)
38fd1f4 
* add support for aws sts creds for registry

Signed-off-by: Tiger Kaovilai <[email protected]>

* remove image-spec replace breaking build

* OADP-1057: STS creds support for internal image backup

Signed-off-by: Tiger Kaovilai <[email protected]>

* Remove non-working code for backing up completed build pods

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>

remove pod backup plugin from main.go

* Resolve Dockerfile perm issues running go build by removing specified UID when copying

Resolves
```
 > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins:
#0 4.584 error obtaining VCS status: exit status 128
#0 4.584        Use -buildvcs=false to disable VCS stamping.
```

Signed-off-by: Tiger Kaovilai <[email protected]>

* update go.mod to openshift/velero #276

* add sts cred secret handling

Signed-off-by: Tiger Kaovilai <[email protected]>

* Pass secret path instead of web_identity_token_file

Signed-off-by: Tiger Kaovilai <[email protected]>

* Update go.mod to openshift/oadp-1.2

---------

Signed-off-by: Tiger Kaovilai <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-velero-plugin that referenced this pull request Aug 22, 2023
@kaovilai
Remove non-working code for backing up completed build pods
ed997d1 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>

remove pod backup plugin from main.go
openshift-merge-robot pushed a commit to openshift/openshift-velero-plugin that referenced this pull request Aug 22, 2023
@openshift-cherrypick-robot @kaovilai
[oadp-1.2] OADP-1057: AWS STS Creds support for internal image backup (…
4a17e00 
…#202)

* add support for aws sts creds for registry

Signed-off-by: Tiger Kaovilai <[email protected]>

* remove image-spec replace breaking build

* OADP-1057: STS creds support for internal image backup

Signed-off-by: Tiger Kaovilai <[email protected]>

* Remove non-working code for backing up completed build pods

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <[email protected]>

remove pod backup plugin from main.go

* Resolve Dockerfile perm issues running go build by removing specified UID when copying

Resolves
```
 > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins:
#0 4.584 error obtaining VCS status: exit status 128
#0 4.584        Use -buildvcs=false to disable VCS stamping.
```

Signed-off-by: Tiger Kaovilai <[email protected]>

* update go.mod to openshift/velero #276

* add sts cred secret handling

Signed-off-by: Tiger Kaovilai <[email protected]>

* Pass secret path instead of web_identity_token_file

Signed-off-by: Tiger Kaovilai <[email protected]>

* Update go.mod to openshift/oadp-1.2

---------

Signed-off-by: Tiger Kaovilai <[email protected]>
Co-authored-by: Tiger Kaovilai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackpiglet blackpiglet blackpiglet approved these changes

@qiuming-best qiuming-best qiuming-best approved these changes

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

@ywk253100 ywk253100 Awaiting requested review from ywk253100

Assignees

@Lyndon-Li Lyndon-Li

Labels
has-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lyndon-Li @SSvilen @qiuming-best @blackpiglet