Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] BIA/RIAv2 e2e tests #6083

Closed
wants to merge 1 commit into from
Closed

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Apr 5, 2023

Thank you for contributing to Velero!

Please add a summary of your change

adds end-to-end tests for BackupItemActionv2/RestoreItemActionv2

Does your change fix a particular issue?

Fixes ##5970

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Scott Seago <[email protected]>
@weshayutin
Copy link
Contributor

@kaovilai @sseago perhaps the e2e tests are now using /v2 api's and this isolated test is not really needed?

@sseago
Copy link
Collaborator Author

sseago commented Feb 26, 2024

@weshayutin so before Velero started using the new V2 methods for CSI snapshots, this would have definitely still been desirable, but now that we've done this, any e2e test that uses CSI snapshots for backup/restore should end up testing these APIs, so it's definitely a lower priority. Is it low enough to say "no need to bother ever"? -- not sure, but maybe.

@sseago
Copy link
Collaborator Author

sseago commented Feb 27, 2024

I'm closing this now. Since Velero 1.12, the CSI plugin uses these new v2 API calls, so any e2e tests which use CSI snapshots or data mover also test the new plugin API calls. This PR was originally started before we had any v2 plugins in use in Velero proper.

There still may be value in this, but it's a low priority now, as the regular e2e suite already exercises these API calls.

@sseago sseago closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants