Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify golangci.yaml file. Resolve found lint issues. #6008

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Mar 21, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Remove the enabled linters setting from Makefile. Move the enabled linters list into golangci.yaml.
Enable more linters, including bodyclose, goheader, misspell, typecheck and unused.

Fix found issues found by linters.

Does your change fix a particular issue?

Fixes #6024

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Mar 21, 2023
@blackpiglet blackpiglet force-pushed the linter_setting branch 3 times, most recently from 4332dc2 to a8a793f Compare March 21, 2023 08:36
@blackpiglet blackpiglet force-pushed the linter_setting branch 2 times, most recently from 648177a to ee39fea Compare March 21, 2023 08:59
@blackpiglet blackpiglet marked this pull request as ready for review March 21, 2023 09:13
@blackpiglet blackpiglet force-pushed the linter_setting branch 2 times, most recently from ddbb654 to 267699b Compare March 21, 2023 12:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #6008 (4800a2d) into main (8235866) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6008      +/-   ##
==========================================
+ Coverage   41.26%   41.29%   +0.03%     
==========================================
  Files         252      251       -1     
  Lines       23380    23369      -11     
==========================================
+ Hits         9647     9650       +3     
+ Misses      12974    12961      -13     
+ Partials      759      758       -1     
Impacted Files Coverage Δ
pkg/builder/json_schema_props_builder.go 0.00% <ø> (ø)
pkg/cmd/cli/backuplocation/delete.go 0.00% <0.00%> (ø)
pkg/cmd/cli/nodeagent/server.go 12.44% <0.00%> (-0.29%) ⬇️
pkg/cmd/server/server.go 5.20% <0.00%> (-0.08%) ⬇️
pkg/controller/backup_deletion_controller.go 57.26% <0.00%> (ø)
pkg/restic/exec_commands.go 15.21% <0.00%> (ø)
pkg/restore/change_pvc_node_selector.go 62.50% <ø> (ø)
pkg/restore/priority.go 95.00% <ø> (ø)
pkg/restore/restore.go 64.86% <0.00%> (+0.52%) ⬆️
pkg/uploader/kopia/progress.go 0.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reasonerjt reasonerjt added this to the v1.11 milestone Mar 22, 2023
@reasonerjt reasonerjt requested a review from qiuming-best March 24, 2023 02:44
@ywk253100 ywk253100 merged commit 15d4472 into vmware-tanzu:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Velero golangci.yaml file and enable more linters.
5 participants