Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reference of itemsnapshotter #5997

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

reasonerjt
Copy link
Contributor

It will be removed as we choose to use BIAv2 for progress monitoring.

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

It will be removed as we choose to use BIAv2 for progress monitoring.

Signed-off-by: Daniel Jiang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #5997 (98001aa) into main (5505110) will increase coverage by 0.65%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #5997      +/-   ##
==========================================
+ Coverage   40.35%   41.01%   +0.65%     
==========================================
  Files         252      248       -4     
  Lines       23213    22660     -553     
==========================================
- Hits         9368     9294      -74     
+ Misses      13133    12659     -474     
+ Partials      712      707       -5     
Impacted Files Coverage Δ
pkg/backup/request.go 100.00% <ø> (ø)
pkg/controller/backup_controller.go 56.82% <0.00%> (+0.05%) ⬆️
pkg/plugin/clientmgmt/manager.go 88.94% <ø> (+8.85%) ⬆️
pkg/plugin/clientmgmt/process/client_builder.go 94.44% <ø> (-0.16%) ⬇️
pkg/plugin/framework/action_resolver.go 5.75% <ø> (+0.75%) ⬆️
pkg/plugin/framework/common/plugin_kinds.go 0.00% <ø> (ø)
pkg/plugin/framework/server.go 0.00% <ø> (ø)
pkg/backup/backup.go 52.14% <100.00%> (+0.13%) ⬆️
pkg/controller/restore_controller.go 67.48% <100.00%> (+0.17%) ⬆️
pkg/restore/restore.go 64.30% <100.00%> (+0.58%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reasonerjt reasonerjt requested review from sseago, Lyndon-Li and ywk253100 and removed request for qiuming-best and blackpiglet March 19, 2023 14:15
@ywk253100 ywk253100 merged commit 4585607 into vmware-tanzu:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants