minor fixes for backup_operations_controller: #5996
Conversation
sseago
force-pushed
the
biav2-second-followon
branch
from
5169981 to
1b3be3b
Compare
Codecov Report
@@ Coverage Diff @@
## main #5996 +/- ##
==========================================
- Coverage 40.35% 40.32% -0.04%
==========================================
Files 252 252
Lines 23213 23217 +4
==========================================
- Hits 9368 9362 -6
- Misses 13133 13143 +10
Partials 712 712
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -82,9 +82,14 @@ func NewBackupOperationsReconciler( | |||
|
|
|||
| func (c *backupOperationsReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| s := kube.NewPeriodicalEnqueueSource(c.logger, mgr.GetClient(), &velerov1api.BackupList{}, c.frequency, kube.PeriodicalEnqueueSourceOption{}) | |||
| gp := kube.NewGenericEventPredicate(func(object client.Object) bool { | |||
| restore := object.(*velerov1api.Restore) | |||
There was a problem hiding this comment.
It should be backup := object.(*velerov1api.Backup) because we want to filter backup in backupOperationsReconciler
There was a problem hiding this comment.
@Lyndon-Li oops. Sorry, copy-and-paste error from the similar fix on the restore side. I just noticed the e2e test failures which are probably related to this.
sseago
force-pushed
the
biav2-second-followon
branch
2 times, most recently
from
b3b537e to
c55de52
Compare
1) default frequency 10s 2) per-reconcile log is now Debug not info 3) added predicate to reduce reconcile events Signed-off-by: Scott Seago <[email protected]>
sseago
force-pushed
the
biav2-second-followon
branch
from
c55de52 to
e500e2d
Compare
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.