-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning/error result to cmd velero backup describe
#5916
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5916 +/- ##
==========================================
- Coverage 40.28% 40.15% -0.13%
==========================================
Files 256 256
Lines 23342 23417 +75
==========================================
Hits 9403 9403
- Misses 13225 13300 +75
Partials 714 714
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Note that #5576 was recently merged that added backup warnings/errors to object store. From a quick look, it seems that this PR allows the newly-added results to be displayed via the backup describer. Let me know if I'm understanding the purpose here correctly and whether this PR adds onto that recently-merged result. In any case, I'll try to give this PR a more detailed look over the next week. |
Thank you for this contribution @allenxu404 , I had intended to add this support post #5576 I will meanwhile also review the PR further |
6f3a007
to
c220891
Compare
@anshulahuja98 Here are some CLI output samples: If errors/warnings exist && backupResults json not exists
If errors/warnings exist && backupResults json exists
|
@sseago Do you have some time to review this PR? |
Yes, the format is consistent with |
I realized that later @allenxu404, and redacted that comment. Good that the function was reused. We would need maintainers to signoff. Good to see closure on the backupresults approach in a more user friendly way. |
44c9d58
to
1134062
Compare
Signed-off-by: allenxu404 <qix2@vmware.com>
@sseago Can you give me another review? I merged the main branch and solved the conflicts. |
Thank you for contributing to Velero!
Please add a summary of your change
backupResult
type to downloadRequest crdvelero backup describe
Does your change fix a particular issue?
Fixes #5200
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.