Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade and fix goreleaser issue #5899

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

anshulahuja98
Copy link
Collaborator

@anshulahuja98 anshulahuja98 commented Feb 22, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5646

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Anshul Ahuja <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #5899 (1730f8b) into main (5555f7d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5899      +/-   ##
==========================================
+ Coverage   40.14%   40.16%   +0.02%     
==========================================
  Files         249      249              
  Lines       22029    22029              
==========================================
+ Hits         8843     8848       +5     
+ Misses      12541    12536       -5     
  Partials      645      645              
Impacted Files Coverage Δ
pkg/uploader/provider/kopia.go 57.25% <0.00%> (+4.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lyndon-Li
Copy link
Contributor

Thanks for this fix! @anshulahuja98

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Thanks @anshulahuja98

@reasonerjt reasonerjt merged commit 357a917 into vmware-tanzu:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goreleaser problem in [main] branch
4 participants