Fix issue 5881 #5894
Merged
Fix issue 5881 #5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
issue-fix-5881
branch
from
b2a32aa to
08b8498
Compare
Codecov Report
@@ Coverage Diff @@
## main #5894 +/- ##
==========================================
- Coverage 40.84% 40.16% -0.68%
==========================================
Files 248 249 +1
Lines 21648 22044 +396
==========================================
+ Hits 8843 8855 +12
- Misses 12160 12543 +383
- Partials 645 646 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reasonerjt
reviewed
Feb 22, 2023
| if volume.PersistentVolumeClaim != nil { | ||
| t.pvcs.Insert(key(pod.Namespace, volume.PersistentVolumeClaim.ClaimName)) | ||
| // Track indicates a volume from a pod should be snapshotted by pod volume backup. | ||
| func (t *pvcSnapshotTracker) Track(pod *corev1api.Pod, volumeName string) { |
There was a problem hiding this comment.
Track .vs. Take is a little confusing, how about pass the status or mode as a parameter and make the naming more explicit?
so the caller will call tracker.Track(pod, volume, VOLUME_SNAPSHOT) or tracker.Track(pod, volume, PODVOLUME_BACKUP)
There was a problem hiding this comment.
I have been thinking of how to clearly distinguish them, actually:
- Track means the volume is decided to be handled by PVB according to rules and annotations. We need to record this situation because we don't want the BIA and volume snapshotter to process the volume again
- Take means the volume has been processed by PVB successfully. We need to record this situation, because we want the volumes that ought to be processed by PVB but missed by the backup with the 1st pod should be processed by backups with other pods. (In the case of RWX mount)
Therefore, if we want to use status, the status should be something like:
- VestedToPVB
- ProcessedByPVB
What do you think? @reasonerjt
reasonerjt
approved these changes
Feb 24, 2023
blackpiglet
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue 5881, enhance the PVB tracker in two modes, Track and Taken
Fix issue #5881