Make restore controller adopting the controller-runtime framework. #5864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
restore_controller_use_controller_runtime
branch
from
4edb17e to
7ab7bf8
Compare
Codecov Report
@@ Coverage Diff @@
## main #5864 +/- ##
==========================================
- Coverage 39.97% 39.94% -0.04%
==========================================
Files 253 253
Lines 22254 22259 +5
==========================================
- Hits 8897 8892 -5
- Misses 12707 12716 +9
- Partials 650 651 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blackpiglet
force-pushed
the
restore_controller_use_controller_runtime
branch
2 times, most recently
from
ca1ae0a to
1156ea5
Compare
blackpiglet
force-pushed
the
restore_controller_use_controller_runtime
branch
4 times, most recently
from
185ef99 to
616e005
Compare
|
Basic E2E test result: https://gist.github.com/blackpiglet/fa25ca51ec7e0f1739fa908e59005d64 |
|
@blackpiglet This has conflicts with restore_controller now (I think due to the refactoring to add backup error/warnings, since restore.Result{} was pulled into a shared package). It would be great to get this merged this week, since I may need to deal with minor merge conflicts from some of these files in my current async PR. |
blackpiglet
force-pushed
the
restore_controller_use_controller_runtime
branch
from
616e005 to
38457d0
Compare
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
restore_controller_use_controller_runtime
branch
from
38457d0 to
c2ac761
Compare
|
@sseago |
sseago
approved these changes
Feb 25, 2023
shubham-pampattiwar
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #5027
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.