Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace k8s.io/apimachinery/pkg/util/clock with k8s.io/utils/clock #5859

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

hezhizhen
Copy link
Contributor

@hezhizhen hezhizhen commented Feb 15, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Replace k8s.io/apimachinery/pkg/util/clock with k8s.io/utils/clock .

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@hezhizhen
Copy link
Contributor Author

/kind changelog-not-required

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #5859 (fb1dc11) into main (5f039b7) will decrease coverage by 0.03%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main    #5859      +/-   ##
==========================================
- Coverage   40.87%   40.84%   -0.03%     
==========================================
  Files         248      248              
  Lines       21648    21648              
==========================================
- Hits         8848     8843       -5     
- Misses      12155    12160       +5     
  Partials      645      645              
Impacted Files Coverage Δ
pkg/cmd/cli/nodeagent/server.go 12.72% <0.00%> (ø)
pkg/cmd/server/server.go 6.61% <0.00%> (ø)
pkg/controller/backup_controller.go 55.88% <0.00%> (ø)
pkg/controller/download_request_controller.go 70.00% <ø> (ø)
pkg/controller/pod_volume_backup_controller.go 38.74% <ø> (ø)
pkg/controller/pod_volume_restore_controller.go 25.00% <0.00%> (ø)
pkg/controller/server_status_request_controller.go 66.15% <ø> (ø)
pkg/controller/restore_controller.go 68.89% <33.33%> (ø)
pkg/controller/backup_repository_controller.go 64.12% <100.00%> (ø)
pkg/controller/gc_controller.go 56.07% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet
Copy link
Contributor

Please add a changelog file according to this document https://velero.io/docs/v1.5/code-standards/#adding-a-changelog.

@hezhizhen
Copy link
Contributor Author

Please add a changelog file according to this document https://velero.io/docs/v1.5/code-standards/#adding-a-changelog.

Done. PTAL

blackpiglet
blackpiglet previously approved these changes Feb 16, 2023
@hezhizhen
Copy link
Contributor Author

@qiuming-best Please take a look.

@hezhizhen
Copy link
Contributor Author

I rebased this PR. @blackpiglet @qiuming-best

@shubham-pampattiwar shubham-pampattiwar merged commit b23c541 into vmware-tanzu:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants