Remove dependency on gofrs/uuid #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
added
the
kind/changelog-not-required
github-actions
bot
added
the
Dependencies
reasonerjt
reviewed
Nov 7, 2022
internal/hook/item_hook_handler.go
Outdated
| @@ -22,7 +22,7 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| uuid "github.com/gofrs/uuid" | |||
| uuid "github.com/google/uuid" | |||
There was a problem hiding this comment.
not quite sure why we need to rename this.
why not just make it
"github.com/google/uuid"
in the import chunk?
There was a problem hiding this comment.
Not sure the history, but IMO, we can rename it
There was a problem hiding this comment.
Done, removed it.
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
remove-gofrs-uuid
branch
from
f943130 to
b06cb9e
Compare
blackpiglet
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary dependency on gofrs/uuid to reduce security risks