Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up golang version to 1.18.8 #5558

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

qiuming-best
Copy link
Contributor

@qiuming-best qiuming-best commented Nov 7, 2022

Signed-off-by: Ming [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

  • Bump up golang version from 1.17.13 to 1.18.8
  • Bump up golangci-lint version to 1.45.0 for v1.27.0 not working in golang v1.18

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-e2e-tests labels Nov 7, 2022
@qiuming-best qiuming-best changed the title Bump up golang 1.18.8 Bump up golang version to 1.18.8 Nov 7, 2022
@qiuming-best qiuming-best added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 7, 2022
@qiuming-best qiuming-best marked this pull request as draft November 7, 2022 03:51
@codecov-commenter
Copy link

Codecov Report

Merging #5558 (e68e688) into release-1.9 (3ca580b) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.9    #5558   +/-   ##
============================================
  Coverage        41.67%   41.67%           
============================================
  Files              214      214           
  Lines            18594    18594           
============================================
  Hits              7749     7749           
  Misses           10262    10262           
  Partials           583      583           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qiuming-best qiuming-best force-pushed the release-1.9 branch 2 times, most recently from 508e401 to 6f8efed Compare November 7, 2022 08:53
@qiuming-best qiuming-best marked this pull request as ready for review November 7, 2022 09:02
@qiuming-best qiuming-best requested review from reasonerjt and blackpiglet and removed request for shubham-pampattiwar November 7, 2022 09:02
@reasonerjt reasonerjt merged commit 4a57c6d into vmware-tanzu:release-1.9 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants