RestoreItemAction v2 design #5408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
Codecov Report
@@ Coverage Diff @@
## main #5408 +/- ##
==========================================
+ Coverage 40.56% 40.59% +0.02%
==========================================
Files 236 236
Lines 20385 20399 +14
==========================================
+ Hits 8269 8280 +11
- Misses 11511 11513 +2
- Partials 605 606 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shubham-pampattiwar
previously approved these changes
Sep 28, 2022
sseago
force-pushed
the
riav2-design
branch
4 times, most recently
from
175c0bf to
4f21641
Compare
This was referenced Oct 25, 2022
Signed-off-by: Scott Seago <[email protected]>
|
Now that the overall design changes have been approved, this PR is ready for review. |
|
@dsu-igeek @ywk253100 @blackpiglet @qiuming-best @Lyndon-Li @reasonerjt Please review as time permits, thank you! |
Lyndon-Li
requested review from
Lyndon-Li,
blackpiglet and
reasonerjt
and removed request for
a-mccarthy
blackpiglet
approved these changes
Dec 9, 2022
shubham-pampattiwar
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Seago [email protected]
This includes necessary changes to support async item action monitoring as well as the Wait for Additional Items feature.
This includes the design for the RestoreItemAction v2 API which is to be implemented in the Velero 1.11 dev cycle.
Thank you for contributing to Velero!
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.