Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BIAv2 impl #5278

Closed
wants to merge 1 commit into from
Closed

Test BIAv2 impl #5278

wants to merge 1 commit into from

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Sep 3, 2022

This provides a test implementation of a v2 BackupItemAction plugin. It is fully functional (built on top of #5271), but the added interface method is for testing purposes only. This should not be merged as-is.

I've also created a velero-plugin-example PR which adds a test v2 plugin to test with this.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago
Copy link
Collaborator Author

sseago commented Sep 3, 2022

vmware-tanzu/velero-plugin-example#66 is a plugin image with a v1 and v2 BIA plugin for testing.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #5278 (328a699) into main (1e138af) will decrease coverage by 0.32%.
The diff coverage is 28.83%.

@@            Coverage Diff             @@
##             main    #5278      +/-   ##
==========================================
- Coverage   40.82%   40.49%   -0.33%     
==========================================
  Files         234      238       +4     
  Lines       20269    20584     +315     
==========================================
+ Hits         8274     8335      +61     
- Misses      11393    11641     +248     
- Partials      602      608       +6     
Impacted Files Coverage Δ
internal/velero/serverstatusrequest.go 0.00% <0.00%> (ø)
pkg/backup/request.go 100.00% <ø> (ø)
pkg/cmd/server/server.go 6.59% <0.00%> (ø)
pkg/controller/server_status_request_controller.go 66.15% <ø> (ø)
pkg/plugin/clientmgmt/process/logrus_adapter.go 17.56% <ø> (ø)
...g/plugin/clientmgmt/process/restartable_process.go 0.00% <0.00%> (ø)
pkg/plugin/framework/action_resolver.go 5.75% <0.00%> (-1.15%) ⬇️
pkg/plugin/framework/backup_item_action.go 0.00% <0.00%> (ø)
pkg/plugin/framework/backup_item_action_client.go 0.00% <0.00%> (ø)
...ramework/backupitemaction/v2/backup_item_action.go 0.00% <0.00%> (ø)
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sseago sseago marked this pull request as draft September 3, 2022 18:51
@github-actions github-actions bot added the Area/Design Design Documents label Sep 5, 2022
@github-actions github-actions bot removed the Area/Design Design Documents label Sep 15, 2022
@sseago sseago force-pushed the biav2-impl branch 2 times, most recently from 850e52b to 1cfd112 Compare September 27, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants