Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the code in pkg/restic/common.go to the proper package #5256

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

ywk253100
Copy link
Contributor

Move the code in pkg/restic/common.go to the proper package

Fixes #5243

Signed-off-by: Wenkai Yin(尹文开) [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@ywk253100 ywk253100 added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 29, 2022
Move the code in pkg/restic/common.go to the proper package

Fixes vmware-tanzu#5243

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@ywk253100 ywk253100 force-pushed the 220829_restic_common branch from 0e1a845 to 4a5647a Compare August 29, 2022 02:05
@ywk253100 ywk253100 requested a review from qiuming-best August 29, 2022 02:05
@codecov-commenter
Copy link

Codecov Report

Merging #5256 (4a5647a) into main (3e30a3d) will increase coverage by 0.00%.
The diff coverage is 76.66%.

@@           Coverage Diff           @@
##             main    #5256   +/-   ##
=======================================
  Coverage   40.81%   40.82%           
=======================================
  Files         233      233           
  Lines       20023    20019    -4     
=======================================
  Hits         8172     8172           
+ Misses      11254    11250    -4     
  Partials      597      597           
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.63% <0.00%> (ø)
pkg/podvolume/util.go 100.00% <ø> (ø)
pkg/repository/manager.go 20.40% <0.00%> (ø)
pkg/restic/common.go 26.86% <ø> (-12.92%) ⬇️
pkg/controller/pod_volume_restore_controller.go 21.62% <50.00%> (ø)
pkg/controller/backup_deletion_controller.go 58.62% <82.60%> (+1.87%) ⬆️
internal/hook/item_hook_handler.go 87.92% <100.00%> (ø)
pkg/restore/restic_restore_action.go 75.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qiuming-best qiuming-best merged commit d8cae1e into vmware-tanzu:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the common code in the pkg/restic/common.go to the proper package
4 participants