restic: don't try to restore PVBs with no snapshotID #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
fix-restic-restore-empty-pvbs
branch
from
4ba126c to
728930f
Compare
|
@carlisia @prydonius @nrb I would like to get this bug fix into v1.2 - PTAL when you can! |
nrb
approved these changes
Nov 4, 2019
Signed-off-by: Steve Kriss <[email protected]>
|
added changelog! |
|
merging since it's got 2 approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
ref #1998 (comment)
If a
PodVolumeBackupdoesn't have asnapshotID, we shouldn't try to restore it because there's nothing to restore. This could be the case if the PVB failed, or if it completed but the volume being backed up was empty, so no snapshot was created.