Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract providers #1985

Merged
merged 10 commits into from
Oct 22, 2019
Merged

Conversation

carlisia
Copy link
Contributor

@carlisia carlisia commented Oct 22, 2019

Closes #1873.

Take II of #1890, now with dependency mess fixed.

TODOs for this PR:

  • Remove provider documentation
  • Add links to external repos for provider documentation
  • Ensure we have clean documentation for how to install any external plugins
  • Resolve the issue of restic needing Azure variables/configuration info
  • Clean up dependencies

Not planned TODO for this PR:

  • 🚫 Remove AWS dependency for restic config

Before merging this PR:

  • get the new repos setup
  • get image builds for the new repos set up
  • make install plugins required

Carlisia added 5 commits October 21, 2019 17:02
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
@carlisia carlisia mentioned this pull request Oct 22, 2019
8 tasks
@carlisia
Copy link
Contributor Author

Sprucing up docs next (tomorrow). Maybe I'll make the install plugins required in a separate PR.

Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks in good shape, just one minor copyright comment!

Re: docs - a reminder that I started #1964 -- if you like what I've got going there, we could use that PR to finalize the install docs.

pkg/persistence/in_memory_object_store.go Show resolved Hide resolved
Carlisia added 4 commits October 22, 2019 13:15
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
Signed-off-by: Carlisia <[email protected]>
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Deep breath...remove 250k lines of code... 😄

@skriss
Copy link
Contributor

skriss commented Oct 22, 2019

@prydonius PTAL

@carlisia
Copy link
Contributor Author

Deep breath...remove 250k lines of code... 😄

Most of which... dependencies!

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the AWS plugin and local minio, and things worked well! Great work @carlisia! lgtm

@prydonius prydonius merged commit d26bf05 into vmware-tanzu:master Oct 22, 2019
@carlisia carlisia deleted the c-1873-extract-providers-II branch October 22, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean out Velero of cloud provider code
3 participants