Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go to support IAM Roles for Service Accounts #1962

Closed
wants to merge 1 commit into from

Conversation

@skriss
Copy link
Contributor

skriss commented Oct 14, 2019

@dcherman thanks for this; you've caught us at an awkward time, as we're in the middle of migrating the in-tree storage provider code to their own repositories. We actually just got the separate AWS repository set up friday: https://github.com/vmware-tanzu/velero-plugin-for-aws

Would you mind making the SDK upgrade as a PR in that repository instead? Thanks!

@dcherman
Copy link
Author

dcherman commented Oct 14, 2019

@skriss It's actually not necessary in that repo it looks like, you're already pulling in a version of the AWS SDK that's new enough for IAM Role support already :)

Unless you feel there's value in merging this, we can probably just close it out and I'll look for the first release of Velero where it's using that new AWS plugin.

Thanks for providing this project btw, it's fantastic!

@skriss
Copy link
Contributor

skriss commented Oct 14, 2019

Ah, didn't realize we had bumped the version there. Sounds like we're set then - appreciate the input regardless! FYI we're planning to release v1.2 around the end of October which will include this update.

Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants