fail on make verify if generated CRDs differ #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funnily enough the CRDs in master are out-of-date, so CI is failing here... this will be fixed once #1898 is merged and this is rebased. |
|
This closes #1905 right? |
skriss
reviewed
Sep 24, 2019
|
Yep - thanks, connected the right issue |
|
#1898 is merged, this can be rebased. |
added 2 commits
September 24, 2019 15:40
Signed-off-by: Adnan Abdulhussein <[email protected]>
Signed-off-by: Adnan Abdulhussein <[email protected]>
prydonius
force-pushed
the
1675-ci-verification
branch
from
1665657 to
6c6da79
Compare
|
rebased! |
nrb
reviewed
Sep 25, 2019
| @@ -17,3 +17,13 @@ | |||
| HACK_DIR=$(dirname "${BASH_SOURCE}") | |||
|
|
|||
| ${HACK_DIR}/update-generated-crd-code.sh --verify-only | |||
There was a problem hiding this comment.
Should the --verfify-only flag here be removed, since it's not being used anymore?
There was a problem hiding this comment.
@nrb since adnan's out for a week, do you want to merge this as-is now and do a followup to remove that flag? would love to get it out of the queue :)
Merged
jessestuart
added a commit
to jessestuart/velero
that referenced
this pull request
Sep 28, 2019
* upstream/master: (38 commits) sync controller: replace revision file with full diff each interval (vmware-tanzu#1892) Increment logging for item backupper (vmware-tanzu#1904) Add LD_LIBRARY_PATH as an env varible for the use of vsphere plugin (vmware-tanzu#1893) Remove unused flag (vmware-tanzu#1913) Use layers in the builder Dockerfile (vmware-tanzu#1907) Fix for vmware-tanzu#1888: check item's original namespace, not remapped one, for inclusion/exclusion (vmware-tanzu#1909) fail on make verify if generated CRDs differ (vmware-tanzu#1906) velero API type changes for structural schema CRDs (vmware-tanzu#1898) Generate CRDs with structural schema (vmware-tanzu#1885) Plan for moving plugin repos (vmware-tanzu#1870) move plugin proto updating into make update (vmware-tanzu#1887) Add features package (vmware-tanzu#1849) GCP: support specifying Cloud KMS key name for backup storage locations (vmware-tanzu#1879) Adds to website (vmware-tanzu#1882) proposal for generating Velero CRDs with structural schema (vmware-tanzu#1875) Improve contributing docs (vmware-tanzu#1852) [doc] Diagram (image) now mentions velero (vmware-tanzu#1877) AWS: add support for arbitrary SSE algorithms, e.g. AES256 (vmware-tanzu#1869) update restic docs for PR vmware-tanzu#1807 (vmware-tanzu#1867) changelog for PR vmware-tanzu#1864 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adnan Abdulhussein [email protected]
fixes #1905