velero install: wait for restic daemonset to be ready #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
install-restic-wait
branch
from
9815dd3 to
a5c63f9
Compare
nrb
reviewed
Sep 9, 2019
changelogs/unreleased/1859-skriss
Outdated
| @@ -0,0 +1 @@ | |||
| velero install: if `--use-restic` and `--wait` are specified, wait for restic daemonset to be ready | |||
There was a problem hiding this comment.
Do we want to mention the timeout here?
I think we're up to a total of 2 minutes between the deployment and daemonset waits.
There was a problem hiding this comment.
sure I can add that.
I didn't bother doing anything more complicated like waiting for both concurrently, as it would require more significant refactoring and it didn't seem super-important to be, but open to others' input on it.
There was a problem hiding this comment.
Yeah, I agree that separate checks with their own timeouts make sense. I'm not sure there's tons of benefit to combining the checks or moving them into concurrent goroutines.
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
install-restic-wait
branch
from
a5c63f9 to
e464dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
Closes #1716
This is a copy-paste with modifications from the code that waits for the deployment to be ready. I looked again at the API docs for daemonsets, and I believe the readiness check I have makes the most sense -- comparing the number of expected scheduled pods to the number of "available" pods, which means pods on proper nodes that have been ready for
spec.minReadySeconds. It seems like the Octant logic could falsely report "ready" if not all pods have been started yet.