Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix excluding additional items with the exclude-from-backup label #1843

Merged
merged 3 commits into from
Sep 10, 2019
Merged

fix excluding additional items with the exclude-from-backup label #1843

merged 3 commits into from
Sep 10, 2019

Conversation

prydonius
Copy link
Contributor

fixes #1835

Signed-off-by: Adnan Abdulhussein [email protected]

Adnan Abdulhussein added 2 commits September 4, 2019 14:56
fix excluding additional items with the exclude-from-backup label
eb3ebd9 
Signed-off-by: Adnan Abdulhussein <[email protected]>
changelog
b7b3189 
Signed-off-by: Adnan Abdulhussein <[email protected]>
@prydonius prydonius requested review from skriss, carlisia and nrb September 4, 2019 22:05
@prydonius prydonius mentioned this pull request Sep 4, 2019
Closed
skriss
skriss suggested changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, but otherwise LGTM. Thanks for adding a test!

pkg/backup/backup_test.go Outdated Show resolved Hide resolved
pkg/backup/item_backupper.go Outdated Show resolved Hide resolved
simplify condition
3d4852f 
Signed-off-by: Adnan Abdulhussein <[email protected]>
@prydonius
Copy link
Contributor Author

thanks @skriss, addressed your comments!

skriss
skriss approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prydonius prydonius mentioned this pull request Sep 5, 2019
Closed
@prydonius
Copy link
Contributor Author

@nrb @carlisia PTAL

carlisia
carlisia approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carlisia carlisia merged commit 26e06da into vmware-tanzu:master Sep 10, 2019
@prydonius prydonius deleted the 1835-exclude-additional-items branch September 10, 2019 20:03
@skriss skriss mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@carlisia carlisia carlisia approved these changes

@nrb nrb Awaiting requested review from nrb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclude-from-backup not working for PersistentVolume
3 participants
@prydonius @carlisia @skriss