Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error formatting #1781

Merged
merged 1 commit into from
Aug 22, 2019
Merged

fix error formatting #1781

merged 1 commit into from
Aug 22, 2019

Conversation

s12chung
Copy link
Contributor

@s12chung s12chung commented Aug 21, 2019 •
edited
Loading

would interpret % as printf formatted strings

example:

# previous (look for %!F(MISSING))
steve-meso-pro:velero main$ ./_output/velero_darwin_amd64/velero backup download velero-kubeaddons-default-20190802002731
An error occurred: "Get https://ac04fbf1bf3114b2c91ef10808c5ba32-2028105485.us-west-2.elb.amazonaws.com:9000/velero/backups/velero-kubeaddons-default-20190802002731/velero-kubeaddons-default-20190802002731.tar.gz?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=minio%!F(MISSING)20190821%!F(MISSING)fallback%!F(MISSING)s3%!F(MISSING)aws4_request&X-Amz-Date=20190821T030947Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Signature=528dc9c40580a99d8e6ef9d62fb7bd97c7d6f6a332cdd898a7907fd40ffbcf9b: x509: certificate signed by unknown authority"

# fixed
steve-meso-pro:velero main$ ./_output/velero_darwin_amd64/velero backup download velero-kubeaddons-default-20190802002731
An error occurred: "Get https://ac04fbf1bf3114b2c91ef10808c5ba32-2028105485.us-west-2.elb.amazonaws.com:9000/velero/backups/velero-kubeaddons-default-20190802002731/velero-kubeaddons-default-20190802002731.tar.gz?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=minio%2F20190821%2Ffallback%2Fs3%2Faws4_request&X-Amz-Date=20190821T031121Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Signature=69309f953ad25d0fff0d1fb02e82c233c927e8dbdf0e85d6376bccdfddfcc5f9: x509: certificate signed by unknown authority"

skriss
skriss approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @s12chung!

@skriss
Copy link
Contributor

skriss commented Aug 21, 2019

holding until after v1.1 is released

@skriss skriss changed the title fix error formatting [do not merge until after v1.1] fix error formatting Aug 21, 2019
fix error formatting
8ae40b5 
would interpret % as printf formatted strings

Signed-off-by: Steven Chung <[email protected]>
@s12chung
Copy link
Contributor Author

whops, noticed I changed it to from %v to %q, which isn't needed. pushed minor change. my bad.

@skriss skriss changed the title [do not merge until after v1.1] fix error formatting fix error formatting Aug 22, 2019
@skriss skriss merged commit efc0be5 into vmware-tanzu:master Aug 22, 2019
@s12chung s12chung deleted the fix_url branch August 22, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s12chung @skriss