Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config-definition.md #139

Closed
wants to merge 1 commit into from
Closed

Update config-definition.md #139

wants to merge 1 commit into from

Conversation

lli-hiya
Copy link
Contributor

"kmsKeyID" should be "kmsKeyId"

@lli-hiya
Update config-definition.md
5489b93 
"kmsKeyID" should be "kmsKeyId"
@heptibot
Copy link

Can one of the admins verify this patch?

@skriss
Copy link
Contributor

skriss commented Oct 19, 2017 •
edited
Loading

Thanks for the PR @lli-hiya! In order to be able to merge, we need you to add signoff to your commit (per https://github.com/heptio/ark/blob/master/CONTRIBUTING.md). You can do this with git commit --amend --signoff and then re-push.

@lli-hiya lli-hiya closed this Oct 19, 2017
jmontleon added a commit to jmontleon/velero that referenced this pull request Nov 11, 2021
@jmontleon
Add required keys for arm builds (vmware-tanzu#139)
1d0cf93
JaydipGabani pushed a commit to JaydipGabani/velero that referenced this pull request Jan 24, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
4963fc2
jmontleon added a commit to jmontleon/velero that referenced this pull request May 6, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
bc75ee7
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Jun 28, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
6d86b5e
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Jul 13, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
d42af72
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Jul 21, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
8fc6e44
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Aug 11, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
172e993
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Sep 26, 2022
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
081b6fd
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 14, 2022
@dymurray @sseago
Dockerfile.ubi/travis local files
053905a 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 24, 2022
@dymurray @sseago
Dockerfile.ubi/travis local files
40e1c2f 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
github-actions bot pushed a commit to kaovilai/velero that referenced this pull request Nov 4, 2022
@dymurray @sseago
Dockerfile.ubi/travis local files
43b816d 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
weshayutin pushed a commit to weshayutin/velero that referenced this pull request Dec 2, 2022
@dymurray @sseago
Dockerfile.ubi/travis local files
7190c6f 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Feb 6, 2023
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
6f08b0e
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Mar 16, 2023
@jmontleon @sseago
Add required keys for arm builds (vmware-tanzu#139)
d3b6939
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Mar 30, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
2d3d495 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Apr 5, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
955c0c7 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request May 5, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
c1509a8 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request May 10, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
ba3f2f4 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Aug 11, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
74b538b 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 2, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
35b1b41 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 24, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
da729d5 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 24, 2023
@dymurray @sseago
Dockerfile.ubi/travis local files
d7b89ac 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
weshayutin pushed a commit to weshayutin/velero that referenced this pull request Mar 19, 2024
@dymurray @sseago
Dockerfile.ubi/travis local files
77e28f4 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
mateusoliveira43 pushed a commit to mateusoliveira43/velero that referenced this pull request Jun 12, 2024
@dymurray @sseago
Dockerfile.ubi/travis local files
2f5ce44 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Jun 18, 2024
@dymurray @kaovilai
Dockerfile.ubi/travis local files
735a9dd 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Jul 22, 2024
@dymurray @sseago
Dockerfile.ubi/travis local files
f06a3e6 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
mateusoliveira43 pushed a commit to mateusoliveira43/velero that referenced this pull request Aug 6, 2024
@dymurray @sseago
Dockerfile.ubi/travis local files
b94deae 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Aug 22, 2024
@dymurray @shubham-pampattiwar
Dockerfile.ubi/travis local files
4149168 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Sep 27, 2024
@dymurray @sseago
Dockerfile.ubi/travis local files
0999e89 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
alromeros pushed a commit to alromeros/velero that referenced this pull request Oct 25, 2024
@ShellyKa13
Adjust plugin and tests to run with Data volume GC (vmware-tanzu#139)
b50e2e1 
* Remove cleanup code

The objects will be cleaned when deleting the namespace
no need to delete objects separatly.

Signed-off-by: Shelly Kagan <[email protected]>

* Enable dv garbage collection and adjust plugin

Make sure not to fail vm backup if datavolume doesnt
exist, instead make sure the PVC does.
In case of datavolumesource volume add explicitly
also its related PVC source in case the datavolume
was already GC.

Signed-off-by: Shelly Kagan <[email protected]>

* Adjust tests framework with enabled DV GC

Skip tests which are worth testing only with/without
gc.

Signed-off-by: Shelly Kagan <[email protected]>

---------

Signed-off-by: Shelly Kagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lli-hiya @heptibot @skriss