Generate CRDs with structural schema (#1885)

* generating CRDs with controller-tools and embedding in binary

Signed-off-by: Adnan Abdulhussein <[email protected]>

hack/build-image/Dockerfile

@@ -21,6 +21,8 @@ RUN mkdir -p /go/src/k8s.io && \
     git clone -b kubernetes-1.15.3 https://github.com/kubernetes/apimachinery && \
     # vendor code-generator go modules to be compatible with pre-1.15
     cd /go/src/k8s.io/code-generator && GO111MODULE=on go mod vendor && \
+    go get -d sigs.k8s.io/controller-tools/cmd/controller-gen && \
+    cd /go/src/sigs.k8s.io/controller-tools && GO111MODULE=on go mod vendor && \
     go get golang.org/x/tools/cmd/goimports && \
     cd /go/src/golang.org/x/tools && \
     git checkout 40a48ad93fbe707101afb2099b738471f70594ec && \

hack/update-generated-crd-code.sh

@@ -28,12 +28,27 @@ if [[ ! -d "${GOPATH}/src/k8s.io/code-generator" ]]; then
   exit 1
 fi
 
-cd ${GOPATH}/src/k8s.io/code-generator
+if [[ ! -d "${GOPATH}/src/sigs.k8s.io/controller-tools" ]]; then
+  echo "sigs.k8s.io/controller-tools missing from GOPATH"
+  exit 1
+fi
 
-./generate-groups.sh \
+${GOPATH}/src/k8s.io/code-generator/generate-groups.sh \
   all \
   github.com/heptio/velero/pkg/generated \
   github.com/heptio/velero/pkg/apis \
   "velero:v1" \
   --go-header-file ${GOPATH}/src/github.com/heptio/velero/hack/boilerplate.go.txt \
   $@
+
+if [[ "$@" == "--verify-only" ]]; then
+  # skip generating CRD manifests
+  exit
+fi
+
+go run ${GOPATH}/src/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go \
+  crd \
+  output:dir=pkg/generated/crds/manifests \
+  paths=./pkg/apis/velero/v1/...
+
+go generate ./pkg/generated/crds

pkg/generated/crds/doc.go

@@ -0,0 +1,4 @@
+// Package crds embeds the controller-tools generated CRD manifests
+package crds
+
+//go:generate go run ../../../hack/crd-gen/main.go